michael/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Files
linux-5.15.y
linux/include/acpi
History
Ahmed Salem 6448774d58 ACPICA: Avoid sequence overread in call to strncmp() 
[ Upstream commit 64b9dfd077 ]

ACPICA commit 8b83a8d88dfec59ea147fad35fc6deea8859c58c

ap_get_table_length() checks if tables are valid by
calling ap_is_valid_header(). The latter then calls
ACPI_VALIDATE_RSDP_SIG(Table->Signature).

ap_is_valid_header() accepts struct acpi_table_header as an argument, so
the signature size is always fixed to 4 bytes.

The problem is when the string comparison is between ACPI-defined table
signature and ACPI_SIG_RSDP. Common ACPI table header specifies the
Signature field to be 4 bytes long[1], with the exception of the RSDP
structure whose signature is 8 bytes long "RSD PTR " (including the
trailing blank character)[2]. Calling strncmp(sig, rsdp_sig, 8) would
then result in a sequence overread[3] as sig would be smaller (4 bytes)
than the specified bound (8 bytes).

As a workaround, pass the bound conditionally based on the size of the
signature being passed.

Link: https://uefi.org/specs/ACPI/6.5_A/05_ACPI_Software_Programming_Model.html#system-description-table-header [1]
Link: https://uefi.org/specs/ACPI/6.5_A/05_ACPI_Software_Programming_Model.html#root-system-description-pointer-rsdp-structure [2]
Link: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wstringop-overread [3]
Link: https://github.com/acpica/acpica/commit/8b83a8d8
Signed-off-by: Ahmed Salem <x0rw3ll@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/2248233.Mh6RI2rZIc@rjwysocki.net
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-06-27 11:05:27 +01:00
..
platform
ACPI: tools: fix compilation error
2021-10-07 19:18:19 +02:00
acbuffer.h
ACPICA: Add _PLD panel positions
2021-06-07 14:04:43 +02:00
acconfig.h
ACPICA: Add support for PlatformRtMechanism OperationRegion handler
2021-06-07 14:04:43 +02:00
acexcep.h
ACPICA: Updated all copyrights to 2021
2021-01-22 15:51:53 +01:00
acnames.h
ACPICA: Add method name "_DIS" For use with aslmethod.c
2021-08-16 16:47:02 +02:00
acoutput.h
ACPICA: Macros should not use a trailing semicolon
2021-08-16 16:47:02 +02:00
acpi_bus.h
ACPI: utils: Fix acpi_evaluate_dsm_typed() redefinition error
2023-07-23 13:47:18 +02:00
acpi_drivers.h
Merge branches 'acpi-pci' and 'acpi-processor'
2021-04-26 17:03:05 +02:00
acpi_io.h
Revert "ACPI: Add memory semantics to acpi_os_map_memory()"
2021-09-23 20:39:36 +02:00
acpi_lpat.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 174
2019-05-30 11:26:41 -07:00
acpi_numa.h
ACPI: NUMA: fix typo in a comment
2021-06-07 16:41:10 +02:00
acpi.h
ACPICA: Updated all copyrights to 2021
2021-01-22 15:51:53 +01:00
acpiosxf.h
ACPICA: Updated all copyrights to 2021
2021-01-22 15:51:53 +01:00
acpixf.h
ACPI: sleep: Avoid breaking S3 wakeup due to might_sleep()
2023-06-28 10:29:42 +02:00
acrestyp.h
ACPICA: ACPI 6.4: add CSI2Bus resource template
2021-04-07 19:09:01 +02:00
actbl1.h
ACPICA: Headers: Add new DBG2 Serial Port Subtypes
2021-08-16 16:47:02 +02:00
actbl2.h
ACPICA: iASL: Add support for the AEST table (data compiler)
2021-08-16 16:47:01 +02:00
actbl3.h
ACPICA: iASL: Fix for WPBT table with no command-line arguments
2021-08-16 16:47:02 +02:00
actbl.h
ACPICA: Updated all copyrights to 2021
2021-01-22 15:51:53 +01:00
actypes.h
ACPICA: Avoid sequence overread in call to strncmp()
2025-06-27 11:05:27 +01:00
acuuid.h
ACPICA: ACPI 6.4: add USB4 capabilities UUID
2021-04-07 19:09:00 +02:00
apei.h
ACPI: APEI: explicit init of HEST and GHES in apci_init()
2022-08-17 14:23:11 +02:00
battery.h
ACPI: battery: include linux/power_supply.h
2020-09-25 18:31:19 +02:00
button.h
ACPI: button: move HIDs to acpi/button.h
2020-02-13 23:36:23 +01:00
cppc_acpi.h
ACPI: CPPC: Make rmw_lock a raw_spin_lock
2024-11-08 16:25:53 +01:00
ghes.h
ACPI: APEI: Fix integer overflow in ghes_estatus_pool_init()
2022-11-10 18:15:34 +01:00
hed.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 428
2019-06-05 17:37:16 +02:00
nfit.h
acpi, nfit: Add function to look up nvdimm device and provide SMBIOS handle
2018-03-14 12:43:50 +01:00
pcc.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 441
2019-06-05 17:37:17 +02:00
pdc_intel.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
processor.h
x86: ACPI: fix CPU hotplug deadlock
2020-04-04 16:28:24 +02:00
reboot.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
video.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00