michael/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Files
linux-6.13.y
linux/sound/core
History
Takashi Iwai 296f7a9e15 ALSA: timer: Don't take register_mutex with copy_from/to_user() 
[ Upstream commit 3424c8f53b ]

The infamous mmap_lock taken in copy_from/to_user() can be often
problematic when it's called inside another mutex, as they might lead
to deadlocks.

In the case of ALSA timer code, the bad pattern is with
guard(mutex)(&register_mutex) that covers copy_from/to_user() -- which
was mistakenly introduced at converting to guard(), and it had been
carefully worked around in the past.

This patch fixes those pieces simply by moving copy_from/to_user() out
of the register mutex lock again.

Fixes: 3923de04c8 ("ALSA: pcm: oss: Use guard() for setup")
Reported-by: syzbot+2b96f44164236dda0f3b@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/67dd86c8.050a0220.25ae54.0059.GAE@google.com
Link: https://patch.msgid.link/20250321172653.14310-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-04-10 14:41:34 +02:00
..
oss
Merge tag 'asoc-fix-v6.12-rc1' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus
2024-10-02 21:29:16 +02:00
seq
ALSA: seq: Avoid module auto-load handling at event delivery
2025-03-13 13:07:41 +01:00
.kunitconfig
ALSA: core: add kunitconfig
2024-03-17 09:36:45 +01:00
compress_offload.c
ALSA: compress_offload: fix remaining descriptor races in sound/core/compress_offload.c
2024-12-30 11:49:38 +01:00
control_compat.c
Merge branch 'topic/control-lookup-rwlock' into for-next
2024-08-09 14:25:24 +02:00
control_led.c
ALSA: control: Avoid WARN() for symlink errors
2024-12-10 12:32:34 +01:00
control.c
Merge tag 'asoc-fix-v6.12-rc1' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into for-linus
2024-10-02 21:29:16 +02:00
ctljack.c
ALSA: Convert strlcpy to strscpy when return value is unused
2021-01-08 09:30:05 +01:00
device.c
ALSA: core: Fix missing return value comments for kernel docs
2022-07-13 13:42:38 +02:00
hrtimer.c
ALSA: hrtimer: Use guard() for locking
2024-02-28 15:01:20 +01:00
hwdep_compat.c
ALSA: compat_ioctl: avoid compat_alloc_user_space
2020-09-21 10:37:07 +02:00
hwdep.c
ALSA: hwdep: Move put_user() call out of scoped_guard() in snd_hwdep_control_ioctl()
2024-03-01 18:10:57 +01:00
info_oss.c
ALSA: info: Use guard() for locking
2024-02-28 15:01:21 +01:00
info.c
ALSA: info: Use guard() for locking
2024-02-28 15:01:21 +01:00
init.c
ALSA: core: add isascii() check to card ID generator
2024-10-03 09:16:58 +02:00
isadma.c
Merge tag 'sound-6.0-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
2022-08-06 10:19:51 -07:00
jack.c
ALSA: core: Remove debugfs at disconnection
2024-05-27 09:28:21 +02:00
Kconfig
ALSA: compress_offload: introduce accel operation mode
2024-10-25 10:53:20 +02:00
Makefile
ALSA: core: Use *-y instead of *-objs in Makefile
2024-05-08 18:17:32 +02:00
memalloc.c
ALSA: memalloc: prefer dma_mapping_error() over explicit address checking
2024-12-20 09:54:12 +01:00
memory.c
ALSA: core: Add memory copy helpers between iov_iter and iomem
2023-08-18 12:18:16 +02:00
misc.c
ALSA: core: Drop snd_print stuff and co
2024-08-08 07:49:47 +02:00
pcm_compat.c
ALSA: pcm: Use guard() for PCM stream locks
2024-02-28 15:01:22 +01:00
pcm_dmaengine.c
ALSA: pcm_dmaengine: Don't synchronize DMA channel when DMA is paused
2024-07-17 10:39:47 +02:00
pcm_drm_eld.c
drm/edid: include drm_eld.h only where required
2023-11-09 16:47:31 +02:00
pcm_iec958.c
ALSA: iec958: Split status creation and fill
2021-06-08 17:05:41 +02:00
pcm_lib.c
ALSA: pcm: Add xrun counter for snd_pcm_substream
2024-08-10 10:40:58 +02:00
pcm_local.h
ALSA: pcm: Revert "ALSA: pcm: rewrite snd_pcm_playback_silence()"
2023-05-05 18:23:48 +02:00
pcm_memory.c
ALSA: pcm: Fix yet more compile warning at replacement with kstrtoul()
2024-09-02 10:17:42 +02:00
pcm_misc.c
ALSA: pcm: Fix breakage of PCM rates used for topology
2024-09-11 16:17:44 +02:00
pcm_native.c
Merge tag 'sound-fix-6.13-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
2024-11-29 13:01:05 -08:00
pcm_param_trace.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
pcm_timer.c
ALSA: pcm_timer: use snd_pcm_direction_name()
2024-08-01 12:50:13 +02:00
pcm_trace.h
tracing/treewide: Remove second parameter of __assign_str()
2024-05-22 20:14:47 -04:00
pcm.c
ALSA: pcm: Add xrun counter for snd_pcm_substream
2024-08-10 10:40:58 +02:00
rawmidi_compat.c
ALSA: rawmidi: Replace with __packed attribute
2023-10-26 09:42:55 +02:00
rawmidi.c
ALSA: rawmidi: Fix kvfree() call in spinlock
2024-11-25 15:48:05 +01:00
seq_device.c
driver core: have match() callback in struct bus_type take a const *
2024-07-03 15:16:54 +02:00
sound_kunit.c
ALSA: core: Fix possible NULL dereference caused by kunit_kzalloc()
2024-11-27 08:06:31 +01:00
sound_oss.c
ALSA: core: Use guard() for locking
2024-02-28 15:01:21 +01:00
sound.c
ALSA: Fix typos in comments across various files
2024-09-30 09:52:31 +02:00
timer_compat.c
ALSA: timer: Use guard() for locking
2024-02-28 15:01:20 +01:00
timer.c
ALSA: timer: Don't take register_mutex with copy_from/to_user()
2025-04-10 14:41:34 +02:00
ump_convert.c
ALSA: ump: Explicitly reset RPN with Null RPN
2024-07-31 15:08:39 +02:00
ump.c
Revert "ALSA: ump: Don't enumeration invalid groups for legacy rawmidi"
2024-12-30 12:40:53 +01:00
vmaster.c
ALSA: vmaster: Return error for invalid input values
2024-06-18 12:00:18 +02:00