michael/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Files
linux-6.17.y
linux/drivers/hid
History
Mavroudis Chatzilazaridis 37b36e0765 HID: logitech-hidpp: Do not assume FAP in hidpp_send_message_sync() 
[ Upstream commit aba7963544 ]

Currently, hidpp_send_message_sync() retries sending the message when the
device returns a busy error code, specifically HIDPP20_ERROR_BUSY, which
has a different meaning under RAP. This ends up being a problem because
this function is used for both FAP and RAP messages.

This issue is not noticeable on older receivers with unreachable devices
since they return HIDPP_ERROR_RESOURCE_ERROR (0x09), which is not equal to
HIDPP20_ERROR_BUSY (0x08).

However, newer receivers return HIDPP_ERROR_UNKNOWN_DEVICE (0x08) which
happens to equal to HIDPP20_ERROR_BUSY, causing unnecessary retries when
the device is not actually busy.

This is resolved by checking if the error response is FAP or RAP and
picking the respective ERROR_BUSY code.

Fixes: 60165ab774 ("HID: logitech-hidpp: rework one more time the retries attempts")
Signed-off-by: Mavroudis Chatzilazaridis <mavchatz@protonmail.com>
Tested-by: Stuart Hayhurst <stuart.a.hayhurst@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2025-12-18 13:59:15 +01:00
..
amd-sfh-hid
HID: amd_sfh: Stop sensor before starting
2025-12-01 11:45:33 +01:00
bpf
HID: bpf: abort dispatch if device destroyed
2025-05-13 15:53:50 +02:00
i2c-hid
HID: i2c-hid: Resolve touchpad issues on Dell systems during S4
2025-11-13 15:37:24 -05:00
intel-ish-hid
HID: intel-ish-hid: Increase ISHTP resume ack timeout to 300ms
2025-08-12 14:49:14 +02:00
intel-thc-hid
HID: intel-thc-hid: intel-quickspi: Add ARL PCI Device Id's
2025-11-24 10:37:25 +01:00
surface-hid
HID: intel-thc: fix CONFIG_HID dependency
2025-02-03 10:56:43 +01:00
usbhid
HID: pidff: PERMISSIVE_CONTROL quirk autodetection
2025-11-13 15:37:02 -05:00
.kunitconfig
HID: input: map battery system charging
2022-12-20 15:30:35 +01:00
hid-a4tech.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-accutouch.c
…
hid-alps.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
hid-apple.c
HID: apple: Add SONiX AK870 PRO to non_apple_keyboards quirk list
2025-12-12 18:40:21 +01:00
hid-appleir.c
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hid-appletb-bl.c
HID: hid-appletb-bl: fix incorrect error message for default brightness
2025-02-18 22:01:54 +01:00
hid-appletb-kbd.c
Merge branch 'for-6.17/amd-sfh' into for-linus
2025-07-31 22:36:25 +02:00
hid-asus.c
HID: asus: add Z13 folio to generic group for multitouch to work
2025-11-13 15:37:21 -05:00
hid-aureal.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-axff.c
…
hid-belkin.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-betopff.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-bigbenff.c
HID: bigbenff: constify fixed up report descriptor
2024-09-05 16:20:56 +02:00
hid-cherry.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-chicony.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-cmedia.c
HID: cmedia: constify fixed up report descriptor
2024-08-27 16:30:43 +02:00
hid-core.c
Merge tag 'hid-for-linus-2025073101' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2025-07-31 21:26:05 -07:00
hid-corsair-void.c
HID: corsair-void: Use to_delayed_work()
2025-04-24 11:56:38 +02:00
hid-corsair.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-cougar.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-cp2112.c
Merge tag 'hid-for-linus-2025092201' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2025-09-22 11:01:37 -07:00
hid-creative-sb0540.c
…
hid-cypress.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-debug.c
Merge commit '89c5214639294' into for-6.17/upstream-fixes
2025-09-12 16:58:28 +02:00
hid-dr.c
HID: dr: constify fixed up report descriptor
2024-09-05 16:20:56 +02:00
hid-elan.c
HID: hid-elan: use default remove for hid device
2022-11-21 22:17:10 +01:00
hid-elecom.c
HID: elecom: Add support for ELECOM M-XT3URBK (018F)
2025-12-12 18:40:22 +01:00
hid-elo.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-emsff.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-evision.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-ezkey.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-ft260.c
…
hid-gaff.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-gembird.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-generic.c
Merge branch 'for-6.13/bpf' into for-linus
2024-11-18 22:02:17 +01:00
hid-gfrm.c
…
hid-glorious.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-goodix-spi.c
HID: hid-goodix-spi: Add OF supports
2024-11-13 10:56:37 +01:00
hid-google-hammer.c
Merge branch 'for-6.15/google' into for-linus
2025-03-26 13:46:56 +01:00
hid-google-stadiaff.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-gt683r.c
…
hid-gyration.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-holtek-kbd.c
HID: holtek-kbd: constify fixed up report descriptor
2024-09-05 16:20:56 +02:00
hid-holtek-mouse.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-holtekff.c
…
hid-hyperv.c
HID: usbhid: Eliminate recurrent out-of-bounds bug in usbhid_parse()
2025-04-24 11:31:25 +02:00
hid-icade.c
…
hid-ids.h
HID: elecom: Add support for ELECOM M-XT3URBK (018F)
2025-12-12 18:40:22 +01:00
hid-input-test.c
HID: input: rename hidinput_set_battery_charge_status()
2025-08-20 20:03:39 +02:00
hid-input.c
HID: hid-input: Extend Elan ignore battery quirk to USB
2025-12-12 18:40:21 +01:00
hid-ite.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-jabra.c
…
hid-kensington.c
HID: Fix spelling mistakes "Kensigton" -> "Kensington"
2024-07-12 18:28:03 +02:00
hid-keytouch.c
HID: keytouch: constify fixed up report descriptor
2024-09-05 16:20:56 +02:00
hid-kye.c
move asm/unaligned.h to linux/unaligned.h
2024-10-02 17:23:23 -04:00
hid-kysona.c
HID: Kysona: Add periodic online check
2025-04-24 11:23:08 +02:00
hid-lcpower.c
HID: add more missing MODULE_DESCRIPTION() macros
2024-07-10 09:11:27 +02:00
hid-led.c
…
hid-lenovo.c
HID: lenovo: fixup Lenovo Yoga Slim 7x Keyboard rdesc
2025-12-12 18:40:20 +01:00
hid-letsketch.c
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hid-lg2ff.c
…
hid-lg3ff.c
HID: hid-lg3ff: remove unused struct lg3ff_device
2024-02-13 11:43:55 +01:00
hid-lg4ff.c
HID: replace scnprintf() with sysfs_emit()
2025-06-20 09:14:43 +02:00
hid-lg4ff.h
…
hid-lg-g15.c
HID: hid-lg-g15: Use standard multicolor LED API
2025-02-07 13:50:59 +01:00
hid-lg.c
HID: lg: constify fixed up report descriptor
2024-09-06 10:06:02 +02:00
hid-lg.h
…
hid-lgff.c
…
hid-logitech-dj.c
HID: logitech: Add ids for G PRO 2 LIGHTSPEED
2025-08-20 20:12:42 +02:00
hid-logitech-hidpp.c
HID: logitech-hidpp: Do not assume FAP in hidpp_send_message_sync()
2025-12-18 13:59:15 +01:00
hid-macally.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-magicmouse.c
HID: magicmouse: use secs_to_jiffies() for battery timeout
2025-07-03 09:41:57 +02:00
hid-maltron.c
HID: maltron: constify fixed up report descriptor
2024-09-05 16:20:56 +02:00
hid-mcp2200.c
treewide: rename GPIO set callbacks back to their original names
2025-08-07 10:07:06 +02:00
hid-mcp2221.c
Merge tag 'hid-for-linus-2025082901' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2025-08-29 07:44:14 -07:00
hid-megaworld.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-mf.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-microsoft.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-monterey.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-multitouch.c
HID: multitouch: fix name of Stylus input devices
2025-10-23 16:24:37 +02:00
hid-nintendo.c
HID: nintendo: Wait longer for initial probe
2025-11-24 10:37:25 +01:00
hid-nti.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-ntrig.c
HID: hid-ntrig: Prevent memory leak in ntrig_report_version()
2025-11-24 10:37:39 +01:00
hid-nvidia-shield.c
treewide: Switch/rename to timer_delete[_sync]()
2025-04-05 10:30:12 +02:00
hid-ortek.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-penmount.c
…
hid-petalynx.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-picolcd_backlight.c
HID: picoLCD: Use backlight power constants
2024-09-05 10:55:15 +02:00
hid-picolcd_cir.c
…
hid-picolcd_core.c
Merge tag 'backlight-next-6.10' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight
2024-05-22 10:45:12 -07:00
hid-picolcd_debugfs.c
…
hid-picolcd_fb.c
Merge tag 'backlight-next-6.13' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight
2024-11-22 16:29:57 -08:00
hid-picolcd_lcd.c
HID: picoLCD: Replace check_fb in favor of struct fb_info.lcd_dev
2024-09-30 16:49:42 +01:00
hid-picolcd_leds.c
…
hid-picolcd.h
…
hid-pl.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-plantronics.c
HID: hid-plantronics: Add mic mute mapping and generalize quirks
2025-02-03 11:09:05 +01:00
hid-playstation.c
HID: playstation: Fix memory leak in dualshock4_get_calibration_data()
2025-11-24 10:37:40 +01:00
hid-primax.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-prodikeys.c
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hid-pxrc.c
HID: pxrc: constify fixed up report descriptor
2024-09-05 16:20:57 +02:00
hid-quirks.c
HID: elecom: Add support for ELECOM M-XT3URBK (018F)
2025-12-12 18:40:22 +01:00
hid-razer.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-redragon.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-retrode.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-rmi.c
HID: rmi: remove #ifdef CONFIG_PM
2023-10-25 18:33:42 +02:00
hid-roccat-arvo.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-arvo.h
…
hid-roccat-common.c
…
hid-roccat-common.h
sysfs: treewide: switch back to bin_attribute::read()/write()
2025-06-17 10:44:13 +02:00
hid-roccat-isku.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-isku.h
…
hid-roccat-kone.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-kone.h
…
hid-roccat-koneplus.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-koneplus.h
…
hid-roccat-konepure.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-kovaplus.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-kovaplus.h
…
hid-roccat-lua.c
sysfs: treewide: switch back to bin_attribute::read()/write()
2025-06-17 10:44:13 +02:00
hid-roccat-lua.h
…
hid-roccat-pyra.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-pyra.h
…
hid-roccat-ryos.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-savu.c
sysfs: treewide: switch back to attribute_group::bin_attrs
2025-06-17 10:44:15 +02:00
hid-roccat-savu.h
…
hid-roccat.c
HID: roccat: make all 'class' structures const
2023-08-14 11:23:35 +02:00
hid-saitek.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-samsung.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-semitek.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-sensor-custom.c
Get rid of 'remove_new' relic from platform driver struct
2024-12-01 15:12:43 -08:00
hid-sensor-hub.c
HID: hid-sensor-hub: don't use stale platform-data on remove
2024-12-17 13:14:06 +00:00
hid-sigmamicro.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-sjoy.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-sony.c
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hid-speedlink.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-steam.c
HID: hid-steam: Use new BTN_GRIP* buttons
2025-08-06 10:02:28 -07:00
hid-steelseries.c
HID: steelseries: Fix STEELSERIES_SRWS1 handling in steelseries_remove()
2025-10-15 12:03:56 +02:00
hid-sunplus.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hid-thrustmaster.c
HID: thrustmaster: fix memory leak in thrustmaster_interrupts()
2025-04-24 11:48:13 +02:00
hid-tivo.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-tmff.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-topre.c
HID: topre: Fix n-key rollover on Realforce R3S TKL boards
2025-02-03 22:59:42 +01:00
hid-topseed.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-twinhan.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-u2fzero.c
hwrng: u2fzero - account for high quality RNG
2022-11-25 17:39:19 +08:00
hid-uclogic-core-test.c
HID: uclogic: Fix a work->entry not empty bug in __queue_work()
2023-10-25 16:25:47 +02:00
hid-uclogic-core.c
Merge branch 'for-6.17/uclogic' into for-linus
2025-07-31 22:54:15 +02:00
hid-uclogic-params-test.c
HID: uclogic: Fix user-memory-access bug in uclogic_params_ugee_v2_init_event_hooks()
2023-10-25 16:25:47 +02:00
hid-uclogic-params.c
HID: uclogic: Fix potential memory leak in error path
2025-11-24 10:37:40 +01:00
hid-uclogic-params.h
HID: uclogic: Add support for XP-PEN Artist 22R Pro
2025-07-03 09:33:38 +02:00
hid-uclogic-rdesc-test.c
module: Convert symbol namespace to string literal
2024-12-02 11:34:44 -08:00
hid-uclogic-rdesc.c
HID: uclogic: Add support for XP-PEN Artist 22R Pro
2025-07-03 09:33:38 +02:00
hid-uclogic-rdesc.h
HID: uclogic: Add support for XP-PEN Artist 22R Pro
2025-07-03 09:33:38 +02:00
hid-udraw-ps3.c
…
hid-universal-pidff.c
HID: pidff: Use direction fix only for conditional effects
2025-11-13 15:37:02 -05:00
hid-viewsonic.c
HID: viewsonic: constify fixed up report descriptor
2024-09-05 16:20:57 +02:00
hid-vivaldi-common.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-vivaldi-common.h
…
hid-vivaldi.c
…
hid-vrc2.c
HID: vrc2: constify fixed up report descriptor
2024-09-05 16:20:57 +02:00
hid-waltop.c
HID: waltop: constify fixed up report descriptor
2024-09-05 16:20:57 +02:00
hid-wiimote-core.c
treewide, timers: Rename from_timer() to timer_container_of()
2025-06-08 09:07:37 +02:00
hid-wiimote-debug.c
HID: hid-wiimote-debug.c: Drop error checking for debugfs_create_file
2023-08-14 11:14:42 +02:00
hid-wiimote-modules.c
…
hid-wiimote.h
…
hid-winwing.c
HID: winwing: Add NULL check in winwing_init_led()
2025-02-03 22:47:32 +01:00
hid-xiaomi.c
HID: xiaomi: constify fixed up report descriptor
2024-09-05 16:20:57 +02:00
hid-xinmo.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-zpff.c
HID: add missing MODULE_DESCRIPTION() macros
2024-06-06 10:52:48 +02:00
hid-zydacron.c
HID: change return type of report_fixup() to const
2024-08-27 16:29:55 +02:00
hidraw.c
HID: hidraw: tighten ioctl command parsing
2025-10-15 12:04:00 +02:00
Kconfig
HID: lenovo: Use KEY_PERFORMANCE instead of ACPI's platform_profile
2025-09-12 16:59:05 +02:00
Makefile
Merge branch 'for-6.15/pidff' into for-linus
2025-03-26 13:54:04 +01:00
uhid.c
[tree-wide] finally take no_llseek out
2024-09-27 08:18:43 -07:00
wacom_sys.c
HID: wacom: fix crash in wacom_aes_battery_handler()
2025-06-11 00:27:10 +02:00
wacom_wac.c
HID: wacom: Add a new Art Pen 2
2025-08-12 14:56:35 +02:00
wacom_wac.h
HID: wacom: Remove static WACOM_PKGLEN_MAX limit
2025-03-04 21:51:04 +01:00
wacom.h
HID: wacom: Improve behavior of non-standard LED brightness values
2025-01-09 09:58:28 +01:00