michael/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Files
linux-6.8.y
linux/tools/perf
History
Namhyung Kim 1dbd4215c7 perf lock contention: Add a missing NULL check 
[ Upstream commit f3408580ba ]

I got a report for a failure in BPF verifier on a recent kernel with
perf lock contention command.  It checks task->sighand->siglock without
checking if sighand is NULL or not.  Let's add one.

  ; if (&curr->sighand->siglock == (void *)lock)
  265: (79) r1 = *(u64 *)(r0 +2624)     ; frame1: R0_w=trusted_ptr_task_struct(off=0,imm=0)
                                        ;         R1_w=rcu_ptr_or_null_sighand_struct(off=0,imm=0)
  266: (b7) r2 = 0                      ; frame1: R2_w=0
  267: (0f) r1 += r2
  R1 pointer arithmetic on rcu_ptr_or_null_ prohibited, null-check it first
  processed 164 insns (limit 1000000) max_states_per_insn 1 total_states 15 peak_states 15 mark_read 5
  -- END PROG LOAD LOG --
  libbpf: prog 'contention_end': failed to load: -13
  libbpf: failed to load object 'lock_contention_bpf'
  libbpf: failed to load BPF skeleton 'lock_contention_bpf': -13
  Failed to load lock-contention BPF skeleton
  lock contention BPF setup failed
  lock contention did not detect any lock contention

Fixes: 1811e82767 ("perf lock contention: Track and show siglock with address")
Reviewed-by: Ian Rogers <irogers@google.com>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/20240409225542.1870999-1-namhyung@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-04-27 17:12:54 +02:00
..
arch
Merge tag 'perf-tools-for-v6.8-1-2024-01-09' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools
2024-01-19 14:25:23 -08:00
bench
libperf cpumap: Replace usage of perf_cpu_map__new(NULL) with perf_cpu_map__new_online_cpus()
2023-12-12 14:55:13 -03:00
dlfilters
perf dlfilter: Add a test for object_code()
2023-09-30 00:09:06 -07:00
Documentation
perf list: Add output file option
2024-01-26 10:51:49 -03:00
include/perf
perf dlfilter: Add al_cleanup()
2023-08-15 16:41:49 -03:00
jvmti
…
pmu-events
perf vendor events amd: Fix Zen 4 cache latency events
2024-03-26 18:17:16 -04:00
python
…
scripts
perf scripts python arm-cs-trace-disasm.py: Do not ignore disam first sample
2023-12-20 14:31:59 -03:00
tests
perf test shell daemon: Make signal test less racy
2024-01-26 10:51:49 -03:00
trace
tools headers uapi: Sync linux/stat.h with the kernel sources to pick STATX_MNT_ID_UNIQUE
2024-01-26 10:51:48 -03:00
ui
perf annotate: Make sure to call symbol__annotate2() in TUI
2024-04-27 17:12:54 +02:00
util
perf lock contention: Add a missing NULL check
2024-04-27 17:12:54 +02:00
.gitignore
perf build: Shellcheck support for OUTPUT directory
2023-12-05 15:46:43 -03:00
Build
perf script: Fix Python support when no libtraceevent
2023-03-15 10:27:07 -03:00
builtin-annotate.c
perf annotate: Add --insn-stat option for debugging
2023-12-23 22:40:17 -03:00
builtin-bench.c
Merge tag 'perf-tools-for-v6.6-1-2023-09-05' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools
2023-09-09 20:06:17 -07:00
builtin-buildid-cache.c
perf buildid-cache: Fix use of uninitialized value
2023-10-12 10:01:56 -07:00
builtin-buildid-list.c
perf util: Move input_name to util
2023-04-10 19:21:31 -03:00
builtin-c2c.c
libperf cpumap: Rename perf_cpu_map__empty() to perf_cpu_map__has_any_cpu_or_is_empty()
2023-12-12 14:55:13 -03:00
builtin-config.c
perf path: Make mkpath thread safe, remove 16384 bytes from .bss
2023-05-28 10:24:14 -03:00
builtin-daemon.c
perf tools: Add missing else to cmd_daemon subcommand condition
2023-06-27 12:09:44 -07:00
builtin-data.c
perf util: Move input_name to util
2023-04-10 19:21:31 -03:00
builtin-diff.c
perf diff: Replaces some ',' as separator with the more usual ';'
2023-07-20 11:43:45 -03:00
builtin-evlist.c
perf util: Move input_name to util
2023-04-10 19:21:31 -03:00
builtin-ftrace.c
libperf cpumap: Replace usage of perf_cpu_map__new(NULL) with perf_cpu_map__new_online_cpus()
2023-12-12 14:55:13 -03:00
builtin-help.c
perf path: Make mkpath thread safe, remove 16384 bytes from .bss
2023-05-28 10:24:14 -03:00
builtin-inject.c
perf record: Lazy load kernel symbols
2023-11-09 13:49:32 -03:00
builtin-kallsyms.c
perf symbol: Remove now unused symbol_conf.sort_by_name
2023-06-23 21:48:49 -07:00
builtin-kmem.c
perf callchain: Use pthread keys for tls callchain_cursor
2023-06-12 15:57:54 -03:00
builtin-kvm.c
perf evsel: Introduce evsel__name_is() method to check if the evsel name is equal to a given string
2023-04-24 14:28:11 -03:00
builtin-kwork.c
perf kwork: Fix a build error on 32-bit
2023-11-21 10:02:38 -08:00
builtin-list.c
perf list: Add output file option
2024-01-26 10:51:49 -03:00
builtin-lock.c
perf lock: Fix a memory leak on an error path
2023-11-27 10:21:27 -03:00
builtin-mem.c
perf addr_location: Add init/exit/copy functions
2023-06-12 15:57:53 -03:00
builtin-probe.c
perf probe: Dynamically allocate params memory
2023-05-28 10:24:02 -03:00
builtin-record.c
perf record: Check conflict between '--timestamp-filename' option and pipe mode before recording
2024-03-26 18:17:01 -04:00
builtin-report.c
perf report: Support data type profiling
2023-12-23 22:39:42 -03:00
builtin-sched.c
libperf rc_check: Add RC_CHK_EQUAL
2023-10-25 13:37:22 -07:00
builtin-script.c
perf: script: fix missing ',' for fields option
2023-10-17 12:40:51 -07:00
builtin-stat.c
perf stat: Combine the -A/--no-aggr and --no-merge options
2023-12-14 18:24:38 -03:00
builtin-timechart.c
perf addr_location: Add init/exit/copy functions
2023-06-12 15:57:53 -03:00
builtin-top.c
perf top: Remove needless malloc(0) call that triggers -Walloc-size
2024-01-26 12:06:12 -03:00
builtin-trace.c
perf env: Introduce perf_env__arch_strerrno()
2023-12-04 16:42:09 -03:00
builtin-version.c
perf version: Add status of bpf skeletons
2023-09-18 16:46:15 -07:00
builtin.h
perf usage: Move usage strings
2023-04-10 19:20:53 -03:00
check-headers.sh
perf tools: Add get_unaligned_leNN()
2023-10-17 12:40:02 -07:00
command-list.txt
perf help: Use HAVE_LIBTRACEEVENT to filter out unsupported commands
2023-01-02 11:51:53 -03:00
CREDITS
…
design.txt
…
Makefile
perf tools: Use "grep -E" instead of "egrep"
2022-12-14 15:28:19 -03:00
Makefile.config
perf probe: Convert to check dwarf_getcfi feature
2023-11-10 09:04:21 -03:00
Makefile.perf
perf bpf: Clean up the generated/copied vmlinux.h
2024-03-26 18:17:02 -04:00
MANIFEST
tools perf: Add arm64 sysreg files to MANIFEST
2023-11-22 11:17:53 -08:00
perf-archive.sh
perf archive: Add new option '--unpack' to expand tarballs
2023-12-20 13:20:45 -03:00
perf-completion.sh
perf shell completion: Support completion of metrics/metricgroups
2023-09-11 10:26:36 -03:00
perf-iostat.sh
…
perf-read-vdso.c
…
perf-sys.h
…
perf.c
perf tools: Add --debug-file option to redirect debug output
2023-11-28 14:14:53 -03:00
perf.h
perf util: Move perf_guest/host declarations
2023-04-10 19:22:05 -03:00