15df28699b
A regression was reported to me recently whereby /dev/fb0 had disappeared
from a PowerBook G3 Series "Wallstreet". The problem shows up when the
"video=ofonly" parameter is passed to the kernel, which is what the
bootloader does when "no video driver" is selected. The cause of the
problem is the "offb" string comparison, which got mangled when it got
refactored. Fix it.
Cc: stable@vger.kernel.org
Fixes: 93604a5ade ("fbdev: Handle video= parameter in video/cmdline.c")
Reported-and-tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
Signed-off-by: Helge Deller <deller@gmx.de>
62 lines
1.4 KiB
C
62 lines
1.4 KiB
C
/*
|
|
* linux/drivers/video/fb_cmdline.c
|
|
*
|
|
* Copyright (C) 2014 Intel Corp
|
|
* Copyright (C) 1994 Martin Schaller
|
|
*
|
|
* 2001 - Documented with DocBook
|
|
* - Brad Douglas <brad@neruo.com>
|
|
*
|
|
* This file is subject to the terms and conditions of the GNU General Public
|
|
* License. See the file COPYING in the main directory of this archive
|
|
* for more details.
|
|
*
|
|
* Authors:
|
|
* Daniel Vetter <daniel.vetter@ffwll.ch>
|
|
*/
|
|
|
|
#include <linux/export.h>
|
|
#include <linux/fb.h>
|
|
#include <linux/string.h>
|
|
|
|
#include <video/cmdline.h>
|
|
|
|
/**
|
|
* fb_get_options - get kernel boot parameters
|
|
* @name: framebuffer name as it would appear in
|
|
* the boot parameter line
|
|
* (video=<name>:<options>)
|
|
* @option: the option will be stored here
|
|
*
|
|
* The caller owns the string returned in @option and is
|
|
* responsible for releasing the memory.
|
|
*
|
|
* NOTE: Needed to maintain backwards compatibility
|
|
*/
|
|
int fb_get_options(const char *name, char **option)
|
|
{
|
|
const char *options = NULL;
|
|
bool is_of = false;
|
|
bool enabled;
|
|
|
|
if (name)
|
|
is_of = !strncmp(name, "offb", 4);
|
|
|
|
enabled = __video_get_options(name, &options, is_of);
|
|
|
|
if (options) {
|
|
if (!strncmp(options, "off", 3))
|
|
enabled = false;
|
|
}
|
|
|
|
if (option) {
|
|
if (options)
|
|
*option = kstrdup(options, GFP_KERNEL);
|
|
else
|
|
*option = NULL;
|
|
}
|
|
|
|
return enabled ? 0 : 1; // 0 on success, 1 otherwise
|
|
}
|
|
EXPORT_SYMBOL(fb_get_options);
|