diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig index 4a698568a7e..ed4b02be0dd 100644 --- a/drivers/pinctrl/mediatek/Kconfig +++ b/drivers/pinctrl/mediatek/Kconfig @@ -2,6 +2,8 @@ if ARCH_MEDIATEK config PINCTRL_MTK depends on PINCTRL_GENERIC + select REGMAP + select SYSCON bool config PINCTRL_MT7622 diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index ff7cefcc8de..b1fdcd18027 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -11,6 +11,10 @@ #include #include #include +#include +#include +#include +#include #include "pinctrl-mtk-common.h" @@ -822,32 +826,17 @@ int mtk_pinctrl_common_probe(struct udevice *dev, * for the interrupt controller, so we only use the 1st one currently. */ num_regmaps = dev_count_phandle_with_args(dev, "mediatek,pctl-regmap", NULL, 0); - if (num_regmaps > ARRAY_SIZE(priv->base)) - return -EINVAL; if (num_regmaps > 0) { - for (i = 0; i < num_regmaps; i++) { - struct ofnode_phandle_args args; - struct udevice *syscon_dev; - int ret; + struct regmap *regmap; - ret = dev_read_phandle_with_args(dev, "mediatek,pctl-regmap", - NULL, 0, i, &args); - if (ret) - return ret; + regmap = syscon_regmap_lookup_by_phandle(dev, "mediatek,pctl-regmap"); + if (IS_ERR(regmap)) + return log_msg_ret("regmap: ", PTR_ERR(regmap)); - ret = uclass_get_device_by_ofnode(UCLASS_SYSCON, - args.node, - &syscon_dev); - if (ret) - return ret; - - addr = dev_read_addr_index(syscon_dev, 0); - if (addr == FDT_ADDR_T_NONE) - return -EINVAL; - - priv->base[i] = (void __iomem *)addr; - } + priv->base[0] = regmap_get_range(regmap, 0); + if (!priv->base[0]) + return log_msg_ret("range: ", -EINVAL); return 0; }