michael/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cmd: led: fix help text for blink subcommand

Browse Source 
The blink subcommand actually requires an additional parameter
(blink-freq) but not the others.

In order to simplify the help text, split the blink subcommand help text
from the off|on|toggle subcommands.

Then, fix the help text so that it is clear that the frequency is
required.

While at it, specify the duty cycle.

Fixes: ffe2052d6e ("dm: led: Add a new 'led' command")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
This commit is contained in:
Quentin Schulz
2025-11-12 18:48:06 +01:00
committed by Tom Rini
parent caa740df9c
commit 29a7fe55c5
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/led.c
View File

@@ -118,16 +118,13 @@ int do_led(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
return 0;
}
#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK)
#define BLINK "|blink [blink-freq in ms]"
#else
#define BLINK ""
#endif
U_BOOT_CMD(
led, 4, 1, do_led,
"manage LEDs",
"<led_label> on|off|toggle" BLINK "\tChange LED state\n"
"<led_label> on|off|toggle\tChange LED state\n"
#if defined(CONFIG_LED_BLINK) || defined(CONFIG_LED_SW_BLINK)
"led <led_label> blink <blink-freq in ms>\tBlink LED (duty cycle 50%)\n"
#endif
"led <led_label>\tGet LED state\n"
"led list\t\tshow a list of LEDs"
);