binman: blob_dtb: improve error message when SPL is not found
When using binman with the '-a spl-dtb=y' flag, if the SPL blob is not found, binman throws a cryptic error message: binman: 'NoneType' object has no attribute 'startswith' Let's improve the error message to explicitly state which SPL blob is missing. This is particularly useful when binman is used as a standalone tool outside the U-Boot source tree. Signed-off-by: Jérémie Dautheribes <jeremie.dautheribes@bootlin.com> [trini: Add '# pragma: no cover' because coverage doesn't seem to like the documentation about this error] Signed-off-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
committed by
Tom Rini
parent
90dc6a8b10
commit
66be03b7ee
@@ -8,6 +8,8 @@
|
||||
from binman.entry import Entry
|
||||
from binman.etype.blob import Entry_blob
|
||||
from dtoc import fdt_util
|
||||
import errno
|
||||
import os
|
||||
import struct
|
||||
|
||||
# This is imported if needed
|
||||
@@ -39,9 +41,16 @@ class Entry_blob_dtb(Entry_blob):
|
||||
(self._node.name, self.prepend))
|
||||
|
||||
def ObtainContents(self, fake_size=0):
|
||||
"""Get the device-tree from the list held by the 'state' module"""
|
||||
"""Get the device-tree from the list held by the 'state' module
|
||||
|
||||
Raises:
|
||||
FileNotFoundError: If the device-tree blob is not found.
|
||||
"""
|
||||
self._filename = self.GetDefaultFilename()
|
||||
self._pathname, _ = self.FdtContents(self.GetFdtEtype())
|
||||
if self._pathname is None:
|
||||
raise FileNotFoundError(errno.ENOENT, # pragma: no cover
|
||||
os.strerror(errno.ENOENT), self._filename)
|
||||
return super().ReadBlobContents()
|
||||
|
||||
def ProcessContents(self):
|
||||
|
||||
Reference in New Issue
Block a user