michael/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

efi_driver: don't leak name in efi_bl_create_block_device()

Browse Source 
blk_create_devicef() uses a copy of parameter name.
We can use a local variable.

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Heinrich Schuchardt
2025-11-05 13:24:26 +01:00
parent 59f2c5a0fa
commit dbed053487
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/efi_driver/efi_block_device.c
View File

@@ -124,7 +124,7 @@ efi_bl_create_block_device(efi_handle_t handle, void *interface)
efi_status_t ret;
int r;
int devnum;
char *name;
char name[18]; /* strlen("efiblk#2147483648") + 1 */
struct efi_block_io *io = interface;
struct efi_blk_plat *plat;
@@ -136,9 +136,6 @@ efi_bl_create_block_device(efi_handle_t handle, void *interface)
if (devnum < 0)
return EFI_OUT_OF_RESOURCES;
name = calloc(1, 18); /* strlen("efiblk#2147483648") + 1 */
if (!name)
return EFI_OUT_OF_RESOURCES;
sprintf(name, "efiblk#%d", devnum);
/* Create driver model udevice for the EFI block io device */
@@ -146,7 +143,6 @@ efi_bl_create_block_device(efi_handle_t handle, void *interface)
devnum, io->media->block_size,
(lbaint_t)io->media->last_block, &bdev)) {
ret = EFI_OUT_OF_RESOURCES;
free(name);
goto err;
}