From 47ae7f4a502cb93ff315995bac6b9a17017935ff Mon Sep 17 00:00:00 2001 From: Gaetan Perrot Date: Thu, 15 Jan 2026 03:09:18 +0900 Subject: [PATCH] pmci: mctp: mctp_i3c_controller: remove dead code in controller start mctp_i3c_controller_start() contains a conditional check on a return code that is never updated, making the error handling path unreachable. Remove the dead code to avoid misleading logic and make the current controller startup behavior explicit. Signed-off-by: Gaetan Perrot --- subsys/pmci/mctp/mctp_i3c_controller.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/subsys/pmci/mctp/mctp_i3c_controller.c b/subsys/pmci/mctp/mctp_i3c_controller.c index 22027384b6e..d229ca27f07 100644 --- a/subsys/pmci/mctp/mctp_i3c_controller.c +++ b/subsys/pmci/mctp/mctp_i3c_controller.c @@ -128,15 +128,11 @@ int mctp_i3c_controller_tx(struct mctp_binding *binding, struct mctp_pktbuf *pkt int mctp_i3c_controller_start(struct mctp_binding *binding) { - int rc = 0; + int rc; struct mctp_binding_i3c_controller *b = CONTAINER_OF(binding, struct mctp_binding_i3c_controller, binding); - if (rc != 0) { - LOG_WRN("Could not do dynamic address assignment"); - } - for (int i = 0; i < b->num_endpoints; i++) { mctp_i3c_endpoint_bind(b->devices[i], b, &b->endpoint_i3c_devs[i]); LOG_INF("Enabling IBI for TARGET %p PID %llx BCR %x",