michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: input: cap12xx Fix integer overflow warning

Browse Source 
Check that calsens values are valid to prevent integer overflow

Coverity-CID: 524767
Fixes #90481

Signed-off-by: Jeremy Dick <jdick@pivotint.com>
This commit is contained in:
Jeremy Dick
2025-05-27 10:09:59 -05:00
committed by Benjamin Cabé
parent da6742b776
commit 621f29e331
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/input/input_cap12xx.c
View File

@@ -41,6 +41,7 @@ LOG_MODULE_REGISTER(cap12xx, CONFIG_INPUT_LOG_LEVEL);
#define REG_CALIB_SENSITIVITY_CONFIG2 0x81
#define CALSENS_BITS 2
#define NUM_CALSENS_PER_REG 4
#define MAX_CALSENS_GAIN 4
struct cap12xx_config {
struct i2c_dt_spec i2c;
@@ -107,6 +108,9 @@ static int cap12xx_set_calsens(const struct i2c_dt_spec *i2c, const uint8_t *cal
for (uint8_t i = 0; i < channels; i += NUM_CALSENS_PER_REG) {
regval = 0;
for (uint8_t j = 0; j < NUM_CALSENS_PER_REG && i + j < channels; j++) {
if (calsens[i + j] > MAX_CALSENS_GAIN) {
return -EINVAL;
}
/* Convert the enumerated sensitivity to the corresponding register value */
regval |= (ilog2(calsens[i + j]) << (CALSENS_BITS * j));
}