From bca0b43be9ea7a08cd3510d21dd8754c32549948 Mon Sep 17 00:00:00 2001 From: Gaetan Perrot Date: Tue, 6 Jan 2026 08:50:54 +0900 Subject: [PATCH] drivers: crypto: intel_sha: make set_resume_length_dw1 void intel_sha_set_resume_length_dw1() never reports errors and always returns 0. The error check at the call site is therefore dead code. Make the function void and drop the unused error handling. Signed-off-by: Gaetan Perrot --- drivers/crypto/crypto_intel_sha.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/crypto_intel_sha.c b/drivers/crypto/crypto_intel_sha.c index 8e5065e41a7..ef99fafd0f3 100644 --- a/drivers/crypto/crypto_intel_sha.c +++ b/drivers/crypto/crypto_intel_sha.c @@ -52,10 +52,9 @@ static int intel_sha_set_resume_length_dw0(struct sha_container *sha, uint32_t l return err; } -static int intel_sha_set_resume_length_dw1(struct sha_container *sha, uint32_t upper_length) +static void intel_sha_set_resume_length_dw1(struct sha_container *sha, uint32_t upper_length) { sha->dfsha->sharldw1.full = upper_length; - return 0; } static int intel_sha_regs_cpy(void *dst, const void *src, size_t len) @@ -116,10 +115,8 @@ static int intel_sha_device_run(const struct device *dev, const void *buf_in, si if (err) { return err; } - err = intel_sha_set_resume_length_dw1(self, self->dfsha->shaaldw1.full); - if (err) { - return err; - } + intel_sha_set_resume_length_dw1(self, self->dfsha->shaaldw1.full); + err = intel_sha_regs_cpy((void *)self->dfsha->initial_vector, (void *)self->dfsha->sha_result, sizeof(self->dfsha->initial_vector));