michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: disk: sdmmc_stm32: error out when no domain clock is provided

Browse Source 
If CONFIG_SDMMC_STM32_CLOCK_CHECK=y but the SDMMC node lacked domain clock,
the driver would perform an out-of-bounds access to priv->pclken[1] and
provide garbage as the "subsystem" in the call to clock_control_get_rate().

Detect this situation and error out with an explicit message instead to
prevent UB and help users.

Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
This commit is contained in:
Mathieu Choplain
2026-01-13 18:00:20 +01:00
committed by Henrik Brix Andersen
parent 9066af6a70
commit e0d6d425bd
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/disk/sdmmc_stm32.c
View File

@@ -187,6 +187,11 @@ static int stm32_sdmmc_clock_enable(struct stm32_sdmmc_priv *priv)
if (IS_ENABLED(CONFIG_SDMMC_STM32_CLOCK_CHECK)) {
uint32_t sdmmc_clock_rate;
if (DT_INST_NUM_CLOCKS(0) <= 1) {
LOG_ERR("No domain clock provided on SDMMC DT node!");
return -ENOTSUP;
}
if (clock_control_get_rate(clock,
(clock_control_subsys_t)&priv->pclken[1],
&sdmmc_clock_rate) != 0) {