michael/linux
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rtc: gamecube: Check the return value of ioremap()

Browse Source 
[ Upstream commit d1220e47e4 ]

The function ioremap() in gamecube_rtc_read_offset_from_sram() can fail
and return NULL, which is dereferenced without checking, leading to a
NULL pointer dereference.

Add a check for the return value of ioremap() and return -ENOMEM on
failure.

Fixes: 86559400b3 ("rtc: gamecube: Add a RTC driver for the GameCube, Wii and Wii U")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Reviewed-by: Link Mauve <kernel@linkmauve.fr>
Link: https://patch.msgid.link/20251126080625.1752-1-vulab@iscas.ac.cn
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Haotian Zhang
2025-11-26 16:06:25 +08:00
committed by Greg Kroah-Hartman
parent 7d3ad63351
commit 15cd9cb494
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/rtc/rtc-gamecube.c
View File

@@ -242,6 +242,10 @@ static int gamecube_rtc_read_offset_from_sram(struct priv *d)
}
hw_srnprot = ioremap(res.start, resource_size(&res));
if (!hw_srnprot) {
pr_err("failed to ioremap hw_srnprot\n");
return -ENOMEM;
}
old = ioread32be(hw_srnprot);
/* TODO: figure out why we use this magic constant. I obtained it by