michael/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

serial: lpuart: Return value from correct variable

Browse Source 
In get_lpuart_clk_rate if the call to clk_get_rate returns an error then
the call to return should pass the value of the error which is in rate
rather than ret which will be 0 as its value is not affected by this
error.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
This commit is contained in:
Andrew Goodbody
2025-08-11 17:25:17 +01:00
committed by Peng Fan
parent dc37adfc04
commit 4d3183723f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/serial/serial_lpuart.c
View File

@@ -129,7 +129,7 @@ static int get_lpuart_clk_rate(struct udevice *dev, u32 *clk_rate)
rate = clk_get_rate(&clk);
if ((long)rate <= 0) {
dev_err(dev, "Failed to get clk rate: %ld\n", (long)rate);
return ret;
return rate;
}
*clk_rate = rate;
return 0;