michael/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ufs: ti-j721e: Correct error detection

Browse Source 
In ti_j721e_ufs_probe there is a call to clk_get_rate but the code after
that attempts to detect an error from that call incorrectly uses
IS_ERR_VALUE.  Instead the test should just be for regular error codes.
The call returns an unsigned long so that needs to be cast to a signed type
first of all.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Anshul Dalal <anshuld@ti.com>
Link: https://patch.msgid.link/20251007-ufs_ti-v2-1-501f575b6947@linaro.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
This commit is contained in:
Andrew Goodbody
2025-10-07 12:42:12 +01:00
committed by Neil Armstrong
parent 23987e1090
commit 6defecd943
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ufs/ti-j721e-ufs.c
View File

@@ -17,7 +17,7 @@
static int ti_j721e_ufs_probe(struct udevice *dev)
{
void __iomem *base;
unsigned int clock;
unsigned long clock;
struct clk clk;
u32 reg = 0;
int ret;
@@ -29,9 +29,9 @@ static int ti_j721e_ufs_probe(struct udevice *dev)
}
clock = clk_get_rate(&clk);
if (IS_ERR_VALUE(clock)) {
if ((long)clock <= 0) {
dev_err(dev, "failed to get rate\n");
return ret;
return clock ? clock : -EIO;
}
base = dev_remap_addr_index(dev, 0);