michael/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

clk: mtk: use IS_ERR_VALUE() to check rate return values

Browse Source 
Replace casting with long to IS_ERR_VALUE() macro to check for error
return values from rate calculation functions. This is the recommended
way to check the return value from clock rate functions.

Signed-off-by: David Lechner <dlechner@baylibre.com>
This commit is contained in:
David Lechner
2026-01-14 16:58:57 -06:00
committed by Tom Rini
parent 04413ed0c1
commit 80cb8a0e89
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/clk/mediatek/clk-mtk.c
View File

@@ -12,6 +12,7 @@
#include <asm/io.h>
#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/err.h>
#include "clk-mtk.h"
@@ -236,10 +237,10 @@ static void mtk_clk_print_rate(struct udevice *dev, int mapped_id)
.dev = dev,
.id = mapped_id,
};
long rate = clk_get_rate(&clk);
ulong rate = clk_get_rate(&clk);
if (rate < 0)
printf(", error! clk_get_rate() failed: %ld", rate);
if (IS_ERR_VALUE(rate))
printf(", error! clk_get_rate() failed: %d", (int)rate);
else
printf(", Rate: %lu Hz", rate);
}
@@ -650,7 +651,7 @@ static ulong mtk_topckgen_get_factor_rate(struct clk *clk, u32 off)
rate = priv->tree->xtal_rate;
}
if (((long)rate) < 0)
if (IS_ERR_VALUE(rate))
return rate;
return mtk_factor_recalc_rate(fdiv, rate);
@@ -974,7 +975,7 @@ static ulong mtk_infrasys_get_factor_rate(struct clk *clk, u32 off)
rate = mtk_clk_find_parent_rate(clk, fdiv->parent, NULL);
}
if (((long)rate) < 0)
if (IS_ERR_VALUE(rate))
return rate;
return mtk_factor_recalc_rate(fdiv, rate);