michael/u-boot
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

exports.c: drop unused dummy function

Browse Source 
The !CONFIG_PHY_AQUANTIA defines were already superfluous since
_exports.h does have a CONFIG_PHY_AQUANTIA, so the entries never
existed. In fact, it couldn't have worked, because the defines would
affect both occurences of the mdio_get_current_dev identifier in the

	EXPORT_FUNC(mdio_get_current_dev, struct mii_dev *,
		    mdio_get_current_dev, void)

so the C code would end up containing four copies of

  gd->jt->dummy = dummy

but struct jt_funcs would not and does not have any 'dummy' member.

Now that nothing in _exports.h refers to dummy(), remove the empty
function.

Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
Reviewed-by: Tom Rini <trini@konsulko.com>
This commit is contained in:
Rasmus Villemoes
2025-09-19 12:09:58 +02:00
committed by Tom Rini
parent eb178c849c
commit a78941bc7f
1 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
common/exports.c
View File

@@ -7,10 +7,6 @@
DECLARE_GLOBAL_DATA_PTR;
__attribute__((unused)) static void dummy(void)
{
}
unsigned long get_version(void)
{
return XF_VERSION;
@@ -18,13 +14,6 @@ unsigned long get_version(void)
#define EXPORT_FUNC(f, a, x, ...) gd->jt->x = f;
#ifndef CONFIG_PHY_AQUANTIA
# define mdio_get_current_dev dummy
# define phy_find_by_mask dummy
# define mdio_phydev_for_ethname dummy
# define miiphy_set_current_dev dummy
#endif
int jumptable_init(void)
{
gd->jt = malloc(sizeof(struct jt_funcs));