michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: gpio: pcf857x: ensure input pins default high for open-drain

Browse Source 
Ensure that pins configured as inputs are driven high in the port
output register, consistent with open-drain operation. This prevents
inputs from being driven low unintentionally and aligns behavior
with hardware expectations.

Signed-off-by: Josia Strack <j.strack98@gmail.com>
This commit is contained in:
Josia Strack
2025-10-10 15:29:12 +02:00
committed by Anas Nashif
parent 4f152eeb37
commit 287ca5b9eb
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/gpio/gpio_pcf857x.c
View File

@@ -135,11 +135,6 @@ static int pcf857x_port_get_raw(const struct device *dev, gpio_port_value_t *val
return -EWOULDBLOCK;
}
if ((~drv_data->pins_cfg.configured_as_outputs & (uint16_t)*value) != (uint16_t)*value) {
LOG_ERR("Pin(s) is/are configured as output which should be input.");
return -EOPNOTSUPP;
}
k_sem_take(&drv_data->lock, K_FOREVER);
/**
@@ -185,6 +180,7 @@ static int pcf857x_port_set_raw(const struct device *dev, uint16_t mask, uint16_
tx_buf = (drv_data->pins_cfg.outputs_state & ~mask);
tx_buf |= (value & mask);
tx_buf ^= toggle;
tx_buf |= ~drv_data->pins_cfg.configured_as_outputs;
sys_put_le16(tx_buf, tx_buf_p);
rc = i2c_write_dt(&drv_cfg->i2c, tx_buf_p, drv_data->num_bytes);
@@ -223,7 +219,7 @@ static int pcf857x_pin_configure(const struct device *dev, gpio_pin_t pin, gpio_
}
if (flags & GPIO_INPUT) {
temp_outputs &= ~BIT(pin);
temp_pins &= ~(1 << pin);
temp_pins |= (1 << pin);
} else if (flags & GPIO_OUTPUT) {
drv_data->pins_cfg.configured_as_outputs |= BIT(pin);
temp_outputs = drv_data->pins_cfg.configured_as_outputs;