michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: dma: sam: implement finite state machine for DMA channel

Browse Source 
Add state machine for config/start/stop/resume/suspend for DMA channels.

Signed-off-by: Tony Han <tony.han@microchip.com>
This commit is contained in:
Tony Han
2025-07-16 13:53:48 +08:00
committed by Johan Hedberg
parent a7f1b709d3
commit 30b4e678ca
1 changed files with 56 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
drivers/dma/dma_sam_xdmac.c
View File

@@ -28,11 +28,19 @@ LOG_MODULE_REGISTER(dma_sam_xdmac);
#define XDMAC_INT_ERR (XDMAC_CIE_RBIE | XDMAC_CIE_WBIE | XDMAC_CIE_ROIE)
#define DMA_CHANNELS_MAX 31
enum dma_state {
DMA_STATE_INIT = 0,
DMA_STATE_CONFIGURED,
DMA_STATE_RUNNING,
DMA_STATE_SUSPENDED,
};
/* DMA channel configuration */
struct sam_xdmac_channel_cfg {
void *user_data;
dma_callback_t callback;
uint32_t data_size;
enum dma_state state;
};
/* Device constant configuration parameters */
@@ -68,6 +76,7 @@ static void sam_xdmac_isr(const struct device *dev)
continue;
}
dev_data->dma_channels[channel].state = DMA_STATE_CONFIGURED;
channel_cfg = &dev_data->dma_channels[channel];
/* Get channel errors */
@@ -180,6 +189,8 @@ int sam_xdmac_transfer_configure(const struct device *dev, uint32_t channel,
/* Set next descriptor configuration */
xdmac->XDMAC_CHID[channel].XDMAC_CNDC = param->ndc;
dev_data->dma_channels[channel].state = DMA_STATE_CONFIGURED;
return 0;
}
@@ -199,6 +210,12 @@ static int sam_xdmac_config(const struct device *dev, uint32_t channel,
return -EINVAL;
}
if (dev_data->dma_channels[channel].state != DMA_STATE_INIT &&
dev_data->dma_channels[channel].state != DMA_STATE_CONFIGURED) {
LOG_ERR("Config Channel %d at invalidate state", channel);
return -EINVAL;
}
__ASSERT_NO_MSG(cfg->source_data_size == cfg->dest_data_size);
__ASSERT_NO_MSG(cfg->source_burst_length == cfg->dest_burst_length);
@@ -327,6 +344,12 @@ int sam_xdmac_transfer_start(const struct device *dev, uint32_t channel)
return -EINVAL;
}
if (dev_data->dma_channels[channel].state != DMA_STATE_CONFIGURED &&
dev_data->dma_channels[channel].state != DMA_STATE_RUNNING) {
LOG_ERR("Start Channel %d at invalidate state", channel);
return -EINVAL;
}
/* Check if the channel is enabled */
if (xdmac->XDMAC_GS & (XDMAC_GS_ST0 << channel)) {
LOG_DBG("Channel %d already enabled", channel);
@@ -338,6 +361,8 @@ int sam_xdmac_transfer_start(const struct device *dev, uint32_t channel)
/* Enable channel */
xdmac->XDMAC_GE = XDMAC_GE_EN0 << channel;
dev_data->dma_channels[channel].state = DMA_STATE_RUNNING;
return 0;
}
@@ -354,6 +379,11 @@ int sam_xdmac_transfer_stop(const struct device *dev, uint32_t channel)
return -EINVAL;
}
if (dev_data->dma_channels[channel].state == DMA_STATE_INIT) {
LOG_ERR("Channel %d not configured", channel);
return -EINVAL;
}
/* Check if the channel is enabled */
if (!(xdmac->XDMAC_GS & (XDMAC_GS_ST0 << channel))) {
return 0;
@@ -368,6 +398,8 @@ int sam_xdmac_transfer_stop(const struct device *dev, uint32_t channel)
/* Clear the pending Interrupt Status bit(s) */
(void)xdmac->XDMAC_CHID[channel].XDMAC_CIS;
dev_data->dma_channels[channel].state = DMA_STATE_CONFIGURED;
return 0;
}
@@ -417,6 +449,16 @@ static int xdmac_suspend(const struct device *dev, uint32_t channel)
return -EINVAL;
}
switch (dev_data->dma_channels[channel].state) {
case DMA_STATE_RUNNING:
break;
case DMA_STATE_SUSPENDED:
return 0;
default:
LOG_ERR("Suspend Channel %d at invalidate state", channel);
return -EINVAL;
}
if (!(xdmac->XDMAC_GS & BIT(channel))) {
LOG_DBG("Channel %d not enabled", channel);
return -EINVAL;
@@ -435,6 +477,8 @@ static int xdmac_suspend(const struct device *dev, uint32_t channel)
xdmac->XDMAC_GRWS |= BIT(channel);
dev_data->dma_channels[channel].state = DMA_STATE_SUSPENDED;
return 0;
}
@@ -451,6 +495,16 @@ static int xdmac_resume(const struct device *dev, uint32_t channel)
return -EINVAL;
}
switch (dev_data->dma_channels[channel].state) {
case DMA_STATE_SUSPENDED:
break;
case DMA_STATE_RUNNING:
return 0;
default:
LOG_ERR("Resume Channel %d at invalidate state", channel);
return -EINVAL;
}
if (!(xdmac->XDMAC_GS & BIT(channel))) {
LOG_DBG("Channel %d not enabled", channel);
return -EINVAL;
@@ -469,6 +523,8 @@ static int xdmac_resume(const struct device *dev, uint32_t channel)
xdmac->XDMAC_GRWR |= BIT(channel);
dev_data->dma_channels[channel].state = DMA_STATE_RUNNING;
return 0;
}