michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tests: bluetooth: classic: Remove self assignment

Browse Source 
When building with clang it warns about self-assignment in the
bluetooth.classic.sdp_s test:

tests/bluetooth/classic/sdp_s/src/sdp_server.c:258:5: error: explicitly
assigning value of variable of type 'const struct shell *' to itself
[-Werror,-Wself-assign]
  258 |         sh = sh;
      |         ~~ ^ ~~
tests/bluetooth/classic/sdp_s/src/sdp_server.c:277:5: error: explicitly
assigning value of variable of type 'const struct shell *' to itself
[-Werror,-Wself-assign]
  277 |         sh = sh;
      |         ~~ ^ ~~
tests/bluetooth/classic/sdp_s/src/sdp_server.c:290:5: error: explicitly
assigning value of variable of type 'const struct shell *' to itself
[-Werror,-Wself-assign]
  290 |         sh = sh;
      |         ~~ ^ ~~
tests/bluetooth/classic/sdp_s/src/sdp_server.c:368:5: error: explicitly
assigning value of variable of type 'const struct shell *' to itself
[-Werror,-Wself-assign]
  368 |         sh = sh;
      |         ~~ ^ ~~
4 errors generated.

The "sh" variable is used later in the functions.

Signed-off-by: Tom Hughes <tomhughes@chromium.org>
This commit is contained in:
Tom Hughes
2026-01-12 16:42:17 -08:00
committed by Fabio Baltieri
parent c1b8c14995
commit 32b63c63ed
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/bluetooth/classic/sdp_s/src/sdp_server.c
View File

@@ -255,8 +255,6 @@ static int cmd_register_sdp_all(const struct shell *sh, size_t argc, char *argv[
{
int err;
sh = sh;
for (size_t i = 0; i < ARRAY_SIZE(spp_rec); i++) {
if (!sdp_rec_reg[i]) {
err = bt_sdp_register_service(&spp_rec[i]);
@@ -274,8 +272,6 @@ static int cmd_register_sdp_large(const struct shell *sh, size_t argc, char *arg
{
int err;
sh = sh;
err = bt_sdp_register_service(&spp_rec_large);
if (err) {
shell_error(sh, "Register SDP large record failed (err %d)", err);
@@ -287,8 +283,6 @@ static int cmd_register_sdp_large_valid(const struct shell *sh, size_t argc, cha
{
int err;
sh = sh;
err = bt_sdp_register_service(&spp_rec_large_valid);
if (err) {
shell_error(sh, "Register SDP large record failed (err %d)", err);
@@ -365,8 +359,6 @@ static int cmd_register_sdp_uuid128(const struct shell *sh, size_t argc, char *a
{
int err;
sh = sh;
err = bt_sdp_register_service(&spp_rec_uuid128);
if (err) {
shell_error(sh, "Register SDP uuid128 failed (err %d)", err);