michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

entropy: mcux_rng: Do not ignore possible error

Browse Source 
Propagate the HAL error otherwise it may return success even
when it fails causing invalid entropy and compromising security.

Signed-off-by: Flavio Ceolin <flavio@hubblenetwork.com>
This commit is contained in:
Flavio Ceolin
2026-01-18 18:52:30 -08:00
committed by Fabio Baltieri
parent 231e72af8e
commit 3d5a3ae075
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/entropy/entropy_mcux_rng.c
View File

@@ -23,11 +23,26 @@ static int entropy_mcux_rng_get_entropy(const struct device *dev,
{
const struct mcux_entropy_config *config = dev->config;
status_t status;
int ret;
status = RNG_GetRandomData(config->base, buffer, length);
__ASSERT_NO_MSG(!status);
return 0;
/* It seems that this function returns either success or
* invalid argument.
*/
switch (status) {
case kStatus_InvalidArgument:
ret = -EINVAL;
break;
case kStatus_Success:
ret = 0;
break;
default:
ret = -ENODATA;
break;
}
return ret;
}
static DEVICE_API(entropy, entropy_mcux_rng_api_funcs) = {