michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers: input: sbus: Fix race and infinite loop

Browse Source 
Under certain conditions report_lock could already be used by the irq
before it was initialized, now we ensure we enable irq after report_lock
is initialized.

Furthermore in some conditions data->xfer_bytes could be equal
SBUS_FRAME_LEN resulting in a infinite loop doing zero reads when
fifo is still holding new bytes

Signed-off-by: Peter van der Perk <peter.vanderperk@nxp.com>
This commit is contained in:
Peter van der Perk
2025-04-07 13:14:36 +02:00
committed by Benjamin Cabé
parent 60d933e278
commit 6a37f325a4
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/input/input_sbus.c
View File

@@ -247,7 +247,7 @@ static void sbus_uart_isr(const struct device *uart_dev, void *user_data)
return;
}
while (uart_irq_rx_ready(uart_dev) && data->xfer_bytes <= SBUS_FRAME_LEN) {
while (uart_irq_rx_ready(uart_dev) && data->xfer_bytes < SBUS_FRAME_LEN) {
if (data->in_sync) {
if (data->xfer_bytes == 0) {
data->last_rx_time = k_uptime_get_32();
@@ -324,10 +324,10 @@ static int input_sbus_init(const struct device *dev)
return ret;
}
uart_irq_rx_enable(config->uart_dev);
k_sem_init(&data->report_lock, 0, 1);
uart_irq_rx_enable(config->uart_dev);
k_thread_create(&data->thread, data->thread_stack,
K_KERNEL_STACK_SIZEOF(data->thread_stack),
(k_thread_entry_t)input_sbus_input_report_thread, (void *)dev, NULL, NULL,