michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fs: virtiofs: fix off-by-one in virtqueue initialization

Browse Source 
REQUEST_QUEUE was passed as queue_num to virtio_init_virtqueues
where REQUEST_QUEUE+1 was required

Signed-off-by: Jakub Michalski <jmichalski@antmicro.com>
This commit is contained in:
Jakub Michalski
2025-09-30 14:47:07 +02:00
committed by Benjamin Cabé
parent d76e0004fe
commit a0dbd67262
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
subsys/fs/virtiofs/virtiofs.c
View File

@@ -31,6 +31,12 @@ LOG_MODULE_REGISTER(virtiofs, CONFIG_VIRTIOFS_LOG_LEVEL);
#define REQUEST_QUEUE 2
#endif
/*
* Currently we are using only one request queue, so we don't have to initialize queues
* after that one
*/
#define QUEUE_COUNT (REQUEST_QUEUE + 1)
struct virtio_fs_config {
char tag[36];
@@ -132,7 +138,7 @@ int virtiofs_init(const struct device *dev, struct fuse_init_out *response)
return ret;
}
ret = virtio_init_virtqueues(dev, REQUEST_QUEUE, virtiofs_queue_enum_cb, NULL);
ret = virtio_init_virtqueues(dev, QUEUE_COUNT, virtiofs_queue_enum_cb, NULL);
if (ret != 0) {
LOG_ERR("failed to initialize fs virtqueues");
return ret;