michael/zephyr
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pmci: mctp: mctp_i3c_controller: remove dead code in controller start

Browse Source 
mctp_i3c_controller_start() contains a conditional check on a return
code that is never updated, making the error handling path
unreachable.

Remove the dead code to avoid misleading logic and make the current
controller startup behavior explicit.

Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>
This commit is contained in:
Gaetan Perrot
2026-01-15 03:09:18 +09:00
committed by Benjamin Cabé
parent 31863b30ae
commit 47ae7f4a50
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
subsys/pmci/mctp/mctp_i3c_controller.c
View File

@@ -128,15 +128,11 @@ int mctp_i3c_controller_tx(struct mctp_binding *binding, struct mctp_pktbuf *pkt
int mctp_i3c_controller_start(struct mctp_binding *binding)
{
int rc = 0;
int rc;
struct mctp_binding_i3c_controller *b =
CONTAINER_OF(binding, struct mctp_binding_i3c_controller, binding);
if (rc != 0) {
LOG_WRN("Could not do dynamic address assignment");
}
for (int i = 0; i < b->num_endpoints; i++) {
mctp_i3c_endpoint_bind(b->devices[i], b, &b->endpoint_i3c_devs[i]);
LOG_INF("Enabling IBI for TARGET %p PID %llx BCR %x",